Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !36863

Fix modal event-listeners during dismiss click

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged GeoSot requested to merge gs-fix-modal-scrollbar-click into main Jul 29, 2022
  • Overview 9
  • Commits 3
  • Pipelines 0
  • Changes 3

Partially regression of #36401.

Fixes modal listeners in order to:

  • ignore clicks on scrollbar
    • mousedown, mouseup listen to scrollbar click
    • click ignores scrollbar click
  • ignores clicks that starts inside .modal-dialog, but ends outside of it
  • react on clicks that start & end outside .modal-dialog

closes: #36855 (closed)

alternative approach https://github.com/twbs/bootstrap/issues/36855#issuecomment-1206174935

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs-fix-modal-scrollbar-click