Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37011

Multiple dropdowns: Fix when inside same tag

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-multiple-dropdowns-on-same-line into main Aug 23, 2022
  • Overview 9
  • Commits 6
  • Pipelines 0
  • Changes 3

Proposal to fix #36803 (closed) as a quick win. I was wondering if the data-target was an idea for v5 or v6.

Solution

Partial revert of #35752. For l.408 -> Use of the previous js to instantiate the dropdown with the great button. Partial revert of #35748. For l.98 -> Use the previous _getMenuElement() code to have the great menu when called with the great button.

How to check the solution

Go on the input group section. Check that the last example (the one with 2 dropdowns) display the great dropdown menu for each dropdown toggle (Action before or Action)

Things remaining

  • Do the unit tests once the solution is approved
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-multiple-dropdowns-on-same-line