Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37034

More consistency for CSS/Sass vars doc for components with dark variants

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-improve-docs-for-css-scss-variables-for-dark-variants into main Aug 26, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 4

Description

This PR is a proposal to bring consistency between dropdowns, carousels and navbars docs which have all a dark variant.

Motivation & Context

This PR is a proposal to bring consistency between dropdowns, carousels and navbars docs which have all a dark variant. Dropdowns documentation is taken as a reference being more detailed:

  • CSS variables mentioning that Customization through CSS variables can be seen on the .dropdown-menu-dark class where we override specific values without adding duplicate CSS selectors.
  • Sass variables separating the Sass variables used for the dark variant

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

N/A

Live previews

  • Carousel > Sass > Variables
  • Navbar > CSS > Variables
  • Navbar > CSS > Sass variables
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-improve-docs-for-css-scss-variables-for-dark-variants