Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37084

Table: active `<tr>` fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-table-active-tr-fix into main Sep 05, 2022
  • Overview 6
  • Commits 10
  • Pipelines 1
  • Changes 3

Fixes #33913. May close #35158.

Based on ffoodd's idea.

Live preview

Solutions

Commits can be split.

  • To allows .active on hoverables rows, I tried to implement https://github.com/twbs/bootstrap/issues/33913#issuecomment-841229905. The main issue was the nesting thing, but seems to be fixed by setting the used variables to initial.
  • The second commit is to fix nested tables background. For example with a .table-dark on the first table, on main is: image

On preview is: image

  • The third one is just a typo error inside the doc.

Checks

  • No regression on table page and surroundings. Couldn't spot any but haven't dig too much.
  • No regression on table variants. Couldn't spot any but haven't dig too much.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-table-active-tr-fix