Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37123

Fix button hover color in cover example

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jtsimoes/cover-example-fix into main Sep 12, 2022
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: jtsimoes

Hovering the button on the Cover example makes the text white, making it impossible to read on the white background.

This is due to the use of .btn-secondary class (which applies color: var(--bs-btn-hover-color) aka #fff on hover) together with the use of .bg-white class.

This PR fix this issue. I decided to simply switch from .btn-secondary to the .btn-light class, since it is the closest thing to a white button that we have at the moment.

Thus, this class changes the button text on hover to black, providing also a nice transition effect (from #333 to #000) that did not exist before.

v5.1 v5.2 This PR
v5.1 v5.2 Now
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jtsimoes/cover-example-fix