Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37200

Ensure Tab keyboard functionality after #37146

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged GeoSot requested to merge gs/test-tabs-keyboard-functionality into main Sep 24, 2022
  • Overview 4
  • Commits 5
  • Pipelines 0
  • Changes 2

Description

After https://github.com/twbs/bootstrap/commit/1510c25e9be4d8f7f2ba23622bfdfd9afebb6598. https://twbs-bootstrap.netlify.app/docs/5.2/components/navs-tabs/#javascript-behavior,

@julien-deramond pointed out:

The user for navigating between the tabs has to do the following:

  • Press "Tab" -> "Home" is focused
  • Press "Right" -> "Profile" is selected (not really focused with the blue outline)
  • Press "Tab" -> "Profile" is focused
  • Press "Right" -> "Contact" is selected (not really focused with the blue outline)
  • Press "Tab" -> "Contact" is focused

/cc @patrickhlauke

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-37200--twbs-bootstrap.netlify.app/docs/5.2/components/navs-tabs/#javascript-behavior
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs/test-tabs-keyboard-functionality