Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37272

Carousel: Adding multiple items in one frame

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-carousel-multiple-images into main Oct 07, 2022
  • Overview 16
  • Commits 13
  • Pipelines 1
  • Changes 3

Description

Strongly based on XhmikosR ideas in #28210.

  • Adding a util function to get siblings elements.
  • Adding a js attribute to carousel to fix the number of items in one frame
  • Add some CSS to have items side by side
  • Removed unused class on generated placeholders

Motivation & Context

Seems to be an asked feature.

Type of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-37272--twbs-bootstrap.netlify.app/docs/5.2/components/carousel/#enable-multiple-items

Related issues

Fixes #29130 Fixes #27652

Still todo

Add tests Better doc May want to add a focus handle on the first child only (and tabindex=-1 on the remaining) for accessibility purpose (avoid dupes on screen readers)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-carousel-multiple-images