Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37354

Docs: rewrite/reorganise carousel docs page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Patrick H. Lauke requested to merge patrickhlauke-docs-carousel-rewrite into main Oct 22, 2022
  • Overview 8
  • Commits 34
  • Pipelines 0
  • Changes 3

Description

Make the carousel docs page more sensible/logically structured:

  • start with static/non-autoplaying examples
  • explicitly mention that carousels currently need to be manually initialized
  • split out and explain autoplaying data-bs-ride="carousel" and the weird "autoplay after first interaction" data-bs-ride="true" behaviour, as well as the fact that when animating, these carousels pause on hover/focus
  • various minor language/wording tweaks

In addition, this now explicitly initialises all carousels, so their touch behaviour will work right after page load (rather than only after the first click on a prev/next button).

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-37354--twbs-bootstrap.netlify.app/docs/5.2/components/carousel/

Related issues

Closes https://github.com/twbs/bootstrap/issues/37295

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: patrickhlauke-docs-carousel-rewrite