Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37494

JS: use rollup to set BS version in js files

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed GeoSot requested to merge gs/use-rollup-replace-for-version into main Nov 14, 2022
  • Overview 11
  • Commits 2
  • Pipelines 0
  • Changes 29

Description

Trying to minimize the changes between different BS versions, we can set a standard string (__BS_VERSION__) inside javascript files and, delegate the replacement job to rollup, while it creates the dist files

The same can be done at css files, using postcss-replace https://www.npmjs.com/package/postcss-replace

Type of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

Live previews

https://deploy-preview-37494--twbs-bootstrap.netlify.app/

  • open console and type bootstrap.Alert.VERSION. You will receive the proper version

Related issues

rel #35010 rel #37516

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gs/use-rollup-replace-for-version