Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37533

Visually-hidden: Remove `position: absolute` for captions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Louis-Maxime Piton requested to merge github/fork/louismaximepiton/main-lmp-visually-hidden-caption into main Nov 22, 2022
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

Remove the position: absolute; from the visually hidden caption, tried to group it with all .visually-hidden. There's maybe a better way ?

Motivation & Context

Main issue: a positioned (or floating) table caption is understood as an anonymous cell of a table. This behavior leads to have an undeclared cell between the thead and the tbody. This leads to the issue: It removes the border-collapse: collapse; effect. More explanations here.

Visual issue

Bordered modifier without .visually-hidden: image

Bordered modifier with .visually-hidden: image

Table divider modifier without .visually-hidden: image

Table divider modifier with .visually-hidden: image

Here is the minimum code:

<table class="table table-bordered">
  <caption class="visually-hidden">Text</caption>
  <thead>
    <tr>
      <th scope="col">#</th>
      <th scope="col">First</th>
      <th scope="col">Last</th>
      <th scope="col">Handle</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <th scope="row">1</th>
      <td>Mark</td>
      <td>Otto</td>
      <td>@mdo</td>
    </tr>
  </tbody>
</table>

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-37533--twbs-bootstrap.netlify.app/docs/5.2/content/tables/

Related issues

NA

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/louismaximepiton/main-lmp-visually-hidden-caption