Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37621

Fix `--bs-form-check-bg` definition

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-fix-input-bg-usage into main Dec 10, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Related issues

Closes #37620 (closed)

Description

Customizing $input-bg change $*-input-bg values. The problematic one was $form-check-input-bg that tried to apply escape-svg() on it. This PR suggests to simply remove unnecessary call to escape-svg() since we're handling colors and not images in this case.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

Testing

  • All use cases depending on $form-check-input-bg still work correctly
  • Modifying $input-bg to #fd0 (for example) doesn't cause anymore any compilation issues
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-fix-input-bg-usage