Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37777

Fix cards color for contextual color mode

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-fix-card-color-for-contextual-dark-mode into main Jan 01, 2023
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

This PR adds a default color for .card so that it gets inherited in all .card-* classes that have corresponding $card-*-color set to null.

In order to test this modification, please double-check that the rendering is not broken:

  • in light mode in the docs
  • in dark mode in the docs
  • with contextual data-bs-theme="dark" for each card example in the docs when displayed in light mode
  • with contextual data-bs-theme="light" for each card example in the docs when displayed in dark mode

Note: I'll add a task into our tracking issue for color modes to check all the components with contextual light/dark mode as well.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-37777--twbs-bootstrap.netlify.app/docs/5.3/components/card/

Related issues

Fixes #37765 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-fix-card-color-for-contextual-dark-mode