Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37811

Docs: enhance colors description table

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-improve-customize-color-doc into main Jan 05, 2023
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

This PR suggests to display slightly differently the colors in the second part of the table in https://getbootstrap.com/docs/5.3/customize/color/#colors so that:

  • --bs-xxx, --bs-xxx-rgb and --bs-xxx-bg-subtle are displayed as background colors
  • --bs-xxx-border-subtle is displayed as a big border
  • --bs-xxx-text is displayed as an actual text

Motivation & Context

We struggled to understand this table with @louismaximepiton when he was trying to find a dark/black text color for another PR.

When you have such a goal in mind and that you can directly in https://getbootstrap.com/docs/5.3/customize/color/#colors, there's --bs-dark-text and the text is displayed as white. IMO it's very hard to understand.

Type of changes

  • Enhancement

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly

Live previews

  • https://deploy-preview-37811--twbs-bootstrap.netlify.app/docs/5.3/customize/color/#colors
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-improve-customize-color-doc