Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37817

Docs: remove some CSS from `.highlight-toolbar` def

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-remove-css-from-highlight-toolbar into main Jan 05, 2023
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Description

This PR removes some CSS code used to define .highlight-toolbar:

  • border: solid var(--bs-border-color); can be dropped safely since it's the default border color
  • border-width: 1px 0; is replaced by border-0 border-top border-bottom
  • .btn-clipboard { margin-top: 0; margin-right: 0 } is useless because we already use utilities in this case

https://github.com/twbs/bootstrap/blob/8a3540803015cf9e1a9406ad7ffbfb264ac72ec9/site/layouts/shortcodes/example.html#L37

Motivation & Context

Less CSS and more utilities

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • All new and existing tests passed

Live previews

  • https://deploy-preview-37817--twbs-bootstrap.netlify.app/docs/5.3/components/accordion/#example (for example) in light/dark mode for non-regression
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-remove-css-from-highlight-toolbar