Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37833

Update colored links, add new `.link-body-emphasis` helper

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge colored-links-emphasis into main Jan 07, 2023
  • Overview 3
  • Commits 4
  • Pipelines 0
  • Changes 3

Rewrites colored links again to use the color property instead of --bs-link-color-rgb value as nav links and more do not set or consume --bs-link-color-rgb. This could be an interesting change to tackle in v6, where components utilize more global CSS variable defaults, but not happening right now. This prevents a breaking change right now.

Also adds a new .link-body-emphasis helper—custom right now, not part of the loop, because we use the loop to turn static hex values into rgb values. With this new class, we don't want to use hex values, so we have to write something custom. Worth noting this could also be a change we make in v6—update $theme-colors to use CSS variables. Maybe, who knows.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: colored-links-emphasis