Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37836

Remove autofocus on theme switch when page is loaded

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-fix-autofocus-on-theme-switch into main Jan 08, 2023
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

From https://github.com/twbs/bootstrap/pull/37780, when our docs website is loaded, the theme switch gets automatically the focus which causes an issue of a11y since we can't go directly on the skip links.

I suppose that this modification was rather made to only give back the focus to the dropdown when a change is made and not during the init phase.

In order to understand what I'm saying, simply load https://twbs-bootstrap.netlify.app/. The focus (blue outline difficult to see) is automatically on the dropdown, then press Tab; "New in v5.3" will be focused instead of the skip links.

I tried to isolate the init phase in the script to force the focus only after. Please double-check that the a11y modifications made in the previous PR are still OK but it seems so.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

  • https://deploy-preview-37836--twbs-bootstrap.netlify.app/
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-fix-autofocus-on-theme-switch