Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37868

Remove outdated comment from `$input-border-color` variable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/erengy/input-border-color into main Jan 12, 2023
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: erengy

Before fc3f4b67, $input-border-color was set to $gray-400. It is now set to var(--bs-border-color) instead, which returns $gray-300. You can see the slight change by comparing v5.2 docs to v5.3 docs, or in the following GIF:

input-border-color

I imagine this change was intentional, as #35857 specifically mentions using a global border-color. In that case, we should remove the comment, as this PR does, to avoid confusion.

Otherwise, $input-border-color should be set to another custom property that translates to $gray-400 as before.

See also #37835 for a similar, recently merged PR.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/erengy/input-border-color