Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37893

Fix `.form-control` in dark mode

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge cm-form-control into main Jan 16, 2023
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 3

Removes the CSS variables for .form-control. The problem here is we're reassigning an earlier custom property --bs-body-bg with a new custom property --bs-form-control-bg, but the value of that original one stays computed to the first instance. Only two ways to combat this is to redeclare the variable for dark mode (adds file size), or to remove the extra custom variable. Chose to do the latter as this matches our other form controls.

Fixes #37891 (closed).

Before and after:

CleanShot 2023-01-16 at 15 36 51@2x

CleanShot 2023-01-16 at 15 35 06@2x

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cm-form-control