Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37936

Remove color picker borders on Chromium based browsers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mewen Le Hô requested to merge github/fork/MewenLeHo/main-mlh-fix-color-picker-borders-chromium into main Jan 23, 2023
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

The PR Update .form-control-color sizing and styles #36156 removes the Firefox-specific border on the swatch of the color picker:

  &::-moz-color-swatch {
    border: 0 !important; // stylelint-disable-line declaration-no-important
    @include border-radius($input-border-radius);
  }

But nothing was made for Chromium based browsers and I don't see why the visual rendering of the color picker should be different on Firefox only.

Motivation & Context

Keep the code consistent between all browsers.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

https://deploy-preview-37936--twbs-bootstrap.netlify.app/docs/5.3/forms/form-control/#color

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/MewenLeHo/main-mlh-fix-color-picker-borders-chromium