Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !37953

Theme color improvements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge theme-color-improvements into main Jan 25, 2023
  • Overview 1
  • Commits 4
  • Pipelines 0
  • Changes 3

This PR revamps our new text emphasis, subtle border color, and subtle background colors. Instead of manually using specific darker or lighter shades (e.g., $blue-300 for subtle primary border), they're now generated based on theme colors using the existing tint-color() and shade-color(). This is the more sensible approach given feedback in #37949 (closed).

This purposely avoids touching the grays for now—too annoying to tweak right now. Down the line in v6, I think we can revamp some theme colors, too:

  • Change meaning of $secondary to allow for new body-secondary and body-tertiary approach in our CSS vars and utilities.
  • Add an accent color that complements primary.
  • Add emphasis and inverse buttons to replace light and dark.

Might be more coming for that as well.

Fixes #37949 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: theme-color-improvements