Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38013

Docs: change colors of danger badges in migration guide

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Julien Déramond requested to merge main-jd-change-danger-badge-colors-in-migration-guide into main Feb 07, 2023
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

Based on the warning badges used in migration guide that work well in light and dark mode, this PR suggests to apply the same kind of modification for the danger badges: <span class="badge bg-danger"> becomes <span class="badge text-danger-emphasis bg-danger-subtle">.

The rendering seems to be more consistent in dark mode and offers a better a11y contrast. However, one might say that the danger information is less highlighted in light mode.

Type of changes

  • Enhancement (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • Migration guide from https://deploy-preview-38013--twbs-bootstrap.netlify.app/docs/5.3/migration/#sass section.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-change-danger-badge-colors-in-migration-guide