Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38025

unify `offcanvas` `keydown` event logic with `modal`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Roni Diwan requested to merge github/fork/Ronid1/ronid1/offcanvas_refactor into main Feb 08, 2023
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 2

Description

Since the offcanvas keydown event listener behaves like the modal keydown listener, the former was refactored like the modal. Making it more readable by using positive conditions instead of negative ones.

Motivation & Context

To make refactor and bugfix separated, a new PR was opened as discussed in this comment.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

N/A

Related issues

Splited from #37968

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Ronid1/ronid1/offcanvas_refactor