Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38037

Fix `$grid-breakpoints` SCSS unit tests init

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-fix-grid-breakpoints-scss-unit-test-init into main Feb 13, 2023
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

This PR changes the values of $grid-breakpoints in scss/tests/utilities/_api.test.scss to be sure that this value is well overriden. Since it was not the case, also added a !global.

If you need to manually test this modification, you can remove the !global and you'll see that even if we expect to change the small and medium values respectively to 333 and 666, the test still passes.

Motivation & Context

Unit test worked because $grid-breakpoints contained the same values for small and medium breakpoints so we didn't detect that the overriden value didn't work.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-fix-grid-breakpoints-scss-unit-test-init