Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38079

Prevent Scrolling back when focus on close

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Ahmed Chelly requested to merge github/fork/ChellyAhmed/offcanvas-scroll-back into main Feb 17, 2023
  • Overview 4
  • Commits 2
  • Pipelines 1
  • Changes 1

Description

This Pull Request is a suggestion to prevent scrolling back to the trigger element on closing off-canvas, all while keeping the behavior of focusing the element unchanged for accessibility. This modification is simply done by adding the preventScroll: true object to the this.focus() method.

Motivation & Context

This PR comes as a better solution for the issue: https://github.com/twbs/bootstrap/issues/38070 . Another PR https://github.com/twbs/bootstrap/pull/38076 is suggested but it solves the issue by completely disabling the focus of the trigger element when the user scrolls. Yet, it is important to focus the trigger element for accessibility.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

I created a codepen link to preview the changes: https://codepen.io/ChellyAhmed/pen/VwGLdbR

Related issues

Closes https://github.com/twbs/bootstrap/issues/38070

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ChellyAhmed/offcanvas-scroll-back