Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38095

Drop unused `--bs-focus-ring-box-shadow` and add documentation for `--bs-focus-ring-{x|y|blur}`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-focus-ring-enhancements into main Feb 21, 2023
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Description

This PR suggests removing --bs-focus-ring-box-shadow which isn't used in the code. It might be considered a read-only custom property but IMHO, it can be misunderstood to have read-only custom properties. Or we could decide at some point to name them differently so that they can be more understandable by Bootstrap users.

This PR also suggests documenting the presence of --bs-focus-ring-x, --bs-focus-ring-y, and --bs-focus-ring-blur by providing an explanation and an example.

Type of changes

  • Enhancement (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-38095--twbs-bootstrap.netlify.app/docs/5.3/helpers/focus-ring/#css-variables
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-focus-ring-enhancements