Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38103

Docs: drop unused icons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-drop-unused-icon into main Feb 22, 2023
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 8

Description

Drop unused icons in the project.

  • Based on https://github.com/twbs/bootstrap/commit/d70b5db2e0aee9ea9a7255d28395278876bf53ba, dropped arrow-right-short which is now used only in examples that declare the SVG on top of the files. So arrow-right-short is not used anymore in the rest of the documentation
  • In the same spirit, I've checked all the site/layouts/partials/icons.html. Everything's used except maybe list; I don't think it is used but I was too afraid to have a regression (searching "list" in our project is a nightmare).
  • While I was checking it, I also checked unused icons on top of the examples. Here are the lists of modified examples that need to be double-checked while reviewing this PR for non-regression:
    • Breadcrumbs
    • Buttons
    • Features
    • Jumbotrons
    • List groups
    • Modals
    • Sidebars

Motivation & Context

Lighten our files.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-38103--twbs-bootstrap.netlify.app
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-drop-unused-icon