Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38125

Offcanvas optional `hide()` when resizing the window

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Elysiome requested to merge github/fork/Elysiome/offcanvas-optional-window-resizing into main Feb 27, 2023
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 3

Description

When the user resizes the window, all offcanvas that are not in the fixed position are hidden. This pull request is intended to make this behavior optional with an option called hideNotFixedOnWindowResizing (true by default). It fixes https://github.com/twbs/bootstrap/issues/37916.

Motivation & Context

In some cases we don't want to hide the offcanvas on window resizing, even when the positions are absolute.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-38125--twbs-bootstrap.netlify.app/

Related issues

https://github.com/twbs/bootstrap/issues/37916

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Elysiome/offcanvas-optional-window-resizing