Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38153

Docs: `.text-body-secondary` appears two times in Utilities > Colors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-fix-utilities-docs-text-body-secondary-displayed-two-times into main 2 years ago
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

On our main branch, .text-body-secondary is mentioned two times with the Utilities > Colors section.

This PR:

  • removes one occurrence of .text-body-secondary
  • gather all .text-body-*s in a "group" separated by break lines to keep consistency with what's been done before after the {{< colors.inline >}} block

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • (N/A) My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-38153--twbs-bootstrap.netlify.app/docs/5.3/utilities/colors/#colors
Compare
  • main (base)

and
  • latest version
    e7a1cb9d
    1 commit, 2 years ago

1 file
+ 1
- 2

    Preferences

    File browser
    Compare changes
site/content/docs/5.3/utilities/colors.md
+ 1
- 2
  • View file @ e7a1cb9d

  • Edit in single-file editor

  • Open in Web IDE


@@ -25,9 +25,8 @@ Color utilities like `.text-*` that generated from our original `$theme-colors`
<p class="text-{{ .name }}-emphasis">.text-{{ .name }}-emphasis</p>
{{- end -}}
{{< /colors.inline >}}
<p class="text-body">.text-body</p>
<p class="text-body-secondary">.text-body-secondary</p>
<p class="text-body">.text-body</p>
<p class="text-body-emphasis">.text-body-emphasis</p>
<p class="text-body-secondary">.text-body-secondary</p>
<p class="text-body-tertiary">.text-body-tertiary</p>
0 Assignees
None
Assign to
Reviewer
Mark Otto's avatar
Mark Otto
Request review from
Labels
2
docs v5
2
docs v5
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
3
3 participants
Mark Otto
Administrator
Julien Déramond
Reference: twbs/bootstrap!38153
Source branch: main-jd-fix-utilities-docs-text-body-secondary-displayed-two-times

Menu

Explore Projects Groups Snippets