Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38175

Docs: consistent usage of CSS sections

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-docs-consistent-usage-of-css-sections into main Mar 06, 2023
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 5

Description

Based on https://github.com/twbs/bootstrap/commit/20ab8219a0caca784483e93083cde269055d0f3a and our recent modifications around custom properties, some sections are sometimes called Sass, Sass variables, CSS, etc.

Based on similar files in these folders, this PR suggests modifications to have consistent "CSS" + "Sass variables" sections in:

  • /components
  • /content
  • /forms

Based on similar files in these folders, this PR suggests modifications to have consistent "Sass mixins" sections in:

  • /components

Based on similar files in these folders, this PR suggests modifications to have consistent "Sass loop" sections in:

  • /components

Warning Not knowing exactly the global approach, this PR doesn't modify remaining ## Sass$ occurrences in /helpers, /layout, and /utilities.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-38175--twbs-bootstrap.netlify.app/docs/5.3/components/dropdowns/#sass-mixins
  • https://deploy-preview-38175--twbs-bootstrap.netlify.app/docs/5.3/components/modal/#sass-loop
  • https://deploy-preview-38175--twbs-bootstrap.netlify.app/docs/5.3/components/placeholders/#css
  • https://deploy-preview-38175--twbs-bootstrap.netlify.app/docs/5.3/content/images/#css
  • https://deploy-preview-38175--twbs-bootstrap.netlify.app/docs/5.3/forms/floating-labels/#css
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-docs-consistent-usage-of-css-sections