Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38192

Remove nesting color modes docs section

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge color-modes-docs-note into main Mar 08, 2023
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

Officially drops full support for nesting light mode components within dark mode components, given the issues around needing to duplicate selectors. For those following along, or finding this later, this is essentially what we'd need to do to properly support nesting light in dark:

.carousel,
.carousel[data-bs-theme="light"],
[data-bs-theme="light"] .carousel {
 //...
}

And this would need to be applied to basically every single selector. For the time being, this just isn't practical, and most likely not even that useful.

Closes #38065.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: color-modes-docs-note