Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38247

Docs: consistent deprecation messages in Close Button dark variant

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julien Déramond requested to merge main-jd-consistent-deprecation-msg-of-dark-variant into main Mar 16, 2023
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Description

Several dark variants of components are deprecated in v5.3.0. Close button message regarding this deprecation is not correctly aligned with the one from the dark carousels for example (see https://twbs-bootstrap.netlify.app/docs/5.3/components/carousel/#dark-variant).

This PR suggests to:

  • add the deprecated-in shortcode
  • change the level of the "Heads up!" message from info to warning

Motivation & Context

Consistency in the doc.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-38247--twbs-bootstrap.netlify.app/docs/5.3/components/close-button/#dark-variant
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: main-jd-consistent-deprecation-msg-of-dark-variant