Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38261

Resolve warnings with Sass 1.59.3

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open tgm requested to merge github/fork/tgm-git/patch-1 into main Mar 17, 2023
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

Resolve warnings in tint-color and shade-color.

Description

When using tint-color or shade-color triggers the following warning:

    ╷
212 │   @return mix(black, $color, $weight);
    │           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    node_modules/bootstrap/scss/_functions.scss 212:11  shade-color()
    src/style/index.scss 90:37                          root stylesheet

Deprecation Warning: $weight: Passing a number without unit % (20) is deprecated.

To preserve current behavior: $weight * 1%

More info: https://sass-lang.com/d/function-units

The issue stems from newer sass versions deprecating variable passing without a unit and this PR just adds units.

Motivation & Context

Every time I build a project I get a several warnings if I have used tint-color or shade-color.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-{your_pr_number}--twbs-bootstrap.netlify.app/

Related issues

Same root cause as https://github.com/twbs/bootstrap/pull/37425

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tgm-git/patch-1