Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !38279

scss: bring light/dark accordion icon color handling to parity

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Saleem Abdulrasool requested to merge github/fork/compnerd/dark-accordion-icon into main Mar 19, 2023
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

The light themed accordion icon is controlled by a set of two variables:

  • $accordion-icon-color
  • $accordion-icon-active-color

The dark themed accordion icon did not have this level of control available and instead would always use $primary-text-emphasis-dark.

Replicate the behaviour to permit individual control over the colours to match the behaviour for the light themed form.

Description

The dark themed accordion does not permit control over the icon colour that the light themed accordion allows.

Motivation & Context

Changing the color of the icon for the dark theme is currently not possible which can cause trouble if the emphasis text colour is desired to be different from the chevron on the accordion.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

  • https://deploy-preview-{your_pr_number}--twbs-bootstrap.netlify.app/

Related issues

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/compnerd/dark-accordion-icon