Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !3976

Fix Opera .clearfix bug when using contenteditable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/benvinegar/master into 2.1.0-wip Jul 01, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: benvinegar

Fixes a bug w/ the .clearfix trick affecting Opera browsers when there is a contenteditable div on the page. We ran into this ourselves w/ Disqus (in Opera 12), but it has been reported by at least one other user on Nicholas Gallagher's blog post:

In Opera 11.62 if on page we have any div.clearfix and any <div contenteditable="true">, the blocks with clearfix have additional height.

http://nicolasgallagher.com/micro-clearfix-hack/#comment-36952

In the comments, Nick suggests using height: 0 or font: 0/0 – we made this fix before finding the blog post (sigh), and found line-height: 0 worked fine.

If you're curious just how much height this added, here's a screen shot of Disqus in Opera 12 before this patch was applied: http://dl.dropbox.com/u/421333/Screenshots/avu~_coot-_-.png

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/benvinegar/master