Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !4627

Add support for custom icons.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/natansh/2.1.1-wip into 2.1.1-wip Aug 23, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: natansh

Ideally, a custom icon should be as easy to add as

.icon-[custom name] {
    background-image: ...;
    background-position: ...;
}

Apparently, this used to work in 2.0.4, but no longer works in 2.1.0 - someone reported this in the mailing group. The issue is that the bootstrap styles in many elements have more specificity now, such as

.navbar-inverse .nav > .active > a > [class^="icon-"]

which makes the browser pick that particular background image (mentioned in the property).

I have been thinking of some solutions and the best I could think of was to have a separate class prefix, like

.custom-icon-[custom name]

I have added support for using this approach in the commit.

Would love to hear/know about any alternate approaches possible.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/natansh/2.1.1-wip