Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !4812

Update dropdown jQuery plugin - submenus, touch and keyboard navigation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/blakeembrey/2.1.1-wip into 2.1.1-wip Aug 29, 2012
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 1

Created by: blakeembrey

As the title says, this enables submenu navigation support to the keyboard (via regular tabbing when dropdown is open), via the keyboard shortcuts - added left and right arrows and via touch events which will fire much quicker and appear smoother by avoiding a click event. Also removed touchstart from triggering the keydown event - not sure why this was ever set?

Also clearmenus now also clear the submenus so when you open the menu back up there isn't a flicker where the submenu will be open from being focused on. The [esc] key will now clear the menus as well (and focus on the parent trigger) as this seems like appropriate behaviour.

If possible, could you advise me on a way I can make a unit test for this so I can have these changes accepted?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/blakeembrey/2.1.1-wip