Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !5022

Multiple modals fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/avalla/multiple-modals into 2.1.2-wip Sep 06, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: avalla

If you want to use a modal on another modal (I know that is a bit strange, but I needed it), when you close the second one, it removes modal-open class from body. If you have a typeahead here on the first one, the dropdown will go behind the modal.

So I fixed this issue removing the class when there is one or less modal opened, with this check:

if ($("div.modal.in").length <= 1)

The close event on second modals doesn't works the first time, the row 93 generate an error:

Uncaught RangeError: Maximum call stack size exceeded

Function called:

this.$element.trigger(e)

so I added the same check there too (I don't know if this could generate any other error, any suggest is welcome :) )

examples: error: http://jsfiddle.net/DtPY4/ fixed: http://jsfiddle.net/KQXqM/

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/avalla/multiple-modals