Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !5176

Enable multiple dropdowns when using attributes instead of javascript

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/paulingalls/2.1.2-wip into 2.1.2-wip Sep 18, 2012
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 5

Created by: paulingalls

Currently, if you use multiple dropdowns in different parts of the page, only one of the dropdowns successfully clears when you click the background. This only occurs if you are not using javascript to toggle, but are relying on the data attributes to enable dropdown behavior.

The change is to the clearMenus function, which now iterates through each dropdown and clears the open tag from its parent. Before this would only clear the open tag from the first parent.

A test has been added that exposes the problem, but passes with the change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/paulingalls/2.1.2-wip