Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !5549

fixes #5336: reorder focus() call to avoid scrolling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/mfansler/2.1.2-wip into 2.1.2-wip Oct 16, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: mfansler

Simple fix to prevent the page from scrolling due to focus being called on the modal before it has finished its transition into view. See Issue #5336.

@fat - I hope you'll let this go with no unit tests since the problem being fixed comes from CSS transitions which can't be tested in QUnit, afaik.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mfansler/2.1.2-wip