Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !5598

Guarantee invokation of `complete()`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/victor-homyakov/patch-1 into master Oct 22, 2012
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: victor-homyakov

Transition end event isn't reliable (browser may not fire it, or delay its firing until next transition, in many circumstances, read more in related issue #5462 (closed) https://github.com/twitter/bootstrap/issues/5462).

In order to guarantee proper inner state of Collapse object (especially Collapse#transitioning, because its invalid state will block all successive transitions) additional callback invokation is added with setTimeout().

Timeout value for setTimeout() should be equal to transition time from component-animation.less - I cannot find a better solution for now.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/victor-homyakov/patch-1