Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !5682

Remove body padding-left, padding-right on tablet screens

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tdooner/master into master Oct 30, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: tdooner

This commit removes the default padding-left and padding-right rules for tablet-sized screens. Adding this padding results in broken full-page-width banners, such as the .jumbotron on Bootstrap's own documentation site.

While it makes sense to attempt to ensure that <body> content does not touch the edge of the screen on tablet devices, any content in the responsive Bootstrap grid already cannot touch the edge, because the .container's width continues to shrink as the page decreases in size, effectively providing the same padding. Specifically, if the browser is 980px large, the .container will be 940px, giving 20px of margin on either side and if the browser is 979px, the .container will be 724px, giving between 127px and 22px of margin on either side.

If content is in the grid, it cannot touch the edge. If content is not in the grid, it's probably because the site designer wants it to be as wide as possible. Removing this default allows for that situation.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tdooner/master