Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !5786

fixes #5494: style invalid fields as invalid regardless of required-ness

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/cvrebert/2.2.2-wip into 2.2.2-wip Nov 05, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: cvrebert

The obvious, simple fix for #5494 (closed). Removes the :required selectors from the :invalid styles so that optional fields with invalid values also get styled.

The commit which originally introduced these styles (1209a375) does not explain the inclusion of the requireds, nor does the blog post to which it links (said post instead justifies the :focuses), so the exclusion of optional fields doesn't seem to have been deliberate / explicitly-intended.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/cvrebert/2.2.2-wip