Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !6151

Fix code block white-space breaks within pre tags.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/tierra/pre-code-white-space-fix into 2.2.2-wip Dec 06, 2012
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: tierra

In #5662, the fix describes a possible problem with using nowrap on code blocks:

It could cause a problem, however. If you were to have a long string of code inside an inline code element with white-space: nowrap enabled: it could break the bounds of the containing element and make things look ugly. This could easily be resolved by using a code block with pre tags surrounding it. I would argue this 'workaround' is actually a best practice anyway.

However, the "workaround" doesn't actually work as shown here: http://jsbin.com/opuhev/1/edit

The practice of using code tags within pre tags is very common with Markdown parsers and Jekyll-powered sites.

This change re-applies pre-wrap styles to code tags within pre tags so the workaround actually works as described: http://jsbin.com/opuhev/2/edit

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tierra/pre-code-white-space-fix