Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !6379

fixes carousel sliding issues

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Yohn/patch-8 into 2.3.0-wip 12 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Yohn

Theres 2 slide fixes in the pull request..

First is when we click on the new indicators and stay hovered on the carousel it still cycles through the rest of the items, not pausing it as it should. to fix this, I added the , mouseover in the beginning of the plugin

The second refers to #5747 (closed) when the pausing feature stops working when you hover on the carousel while its in the middle of sliding. In that issue. @andreif pointed out that if we remove the this.cycle() from the pause function it works as expected..

I'm not sure how I would go about creating the tests for this, which is why I didnt include it.. is there a way to trigger the hover effect? I did update the carousel plugin on my local machine and ran the tests and it passed

Compare
  • 2.3.0-wip (base)

and
  • latest version
    620338cb
    1 commit, 2 years ago

1 file
+ 2
- 3

    Preferences

    File browser
    Compare changes
js/bootstrap-carousel.js
+ 2
- 3
  • View file @ 620338cb


@@ -31,7 +31,7 @@
this.$indicators = this.$element.find('.carousel-indicators')
this.options = options
this.options.pause == 'hover' && this.$element
.on('mouseenter', $.proxy(this.pause, this))
.on('mouseenter, mouseover', $.proxy(this.pause, this))
.on('mouseleave', $.proxy(this.cycle, this))
}
@@ -74,7 +74,6 @@
if (!e) this.paused = true
if (this.$element.find('.next, .prev').length && $.support.transition.end) {
this.$element.trigger($.support.transition.end)
this.cycle()
}
clearInterval(this.interval)
this.interval = null
@@ -203,4 +202,4 @@
e.preventDefault()
})
}(window.jQuery);
\ No newline at end of file
}(window.jQuery);
0 Assignees
None
Assign to
Reviewer
XhmikosR's avatar
XhmikosR
Request review from
Labels
2
css v5
2
css v5
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: twbs/bootstrap!30782
Source branch: github/fork/Yohn/patch-8

Menu

Explore Projects Groups Snippets