Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !6488

Remove touchstart from bootstrap-dropdown.js.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/nanek/dropdowns-remove-touchstart into 2.3.0-wip Jan 08, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: nanek

It would be great to remove listening to touchstart from the bootstrap dropdowns. This would make it consistent with the rest of the bootstrap components.

It seems like either all clickable elements should be listening for touchstart or none of them should be. I agree with the comment from https://github.com/twitter/bootstrap/issues/3772#issuecomment-11563061

FastClick works great with Bootstrap except for the bootstrap-dropdowns because they also listen for touchstart which then causes the dropdown to open and then immediately close. See https://github.com/ftlabs/fastclick/issues/48 for more info. Removing touchstart from bootstrap dropdowns would fix this issue and make all of the bootstrap controls behave the same.

Thanks!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nanek/dropdowns-remove-touchstart