Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !6822

Typeahead updates

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/blakeembrey/typeahead-updater into 2.3.0-wip Feb 06, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 4

Created by: blakeembrey

This is to reopen my previous PR from #6487

Typeahead updater

Small change so that if the typeahead updater returns undefined it will no longer wipe out the input value. This allows much greater flexibility to work with the typeahead updater.

Typeahead container

The new insertAfter method for typeaheads is creating issues inside control groups and other things that rely on :last-child selectors. Added the container option which matches the tooltip implementation.

Use case

On http://letushelp.net.au/join/ we are required to have separate input fields for each of the address fields. Since the typeahead and backend is giving full strings, it is split up between input fields in the typeahead updater function. Since the input field could be any that initiated the function, it doesn't take into account which input field is currently active and is already set during the updater function. Returning nothing at the end wipes out the previously inserted value.

The typeahead container is required in the same instances the tooltip container was required. Since it now uses insertAfter it breaks pseudo CSS selectors and sibling selectors found in Bootstrap, such as found in the control group.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/blakeembrey/typeahead-updater