Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !7130

Rename tooltip visibility events to be safer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/C3/tooltip-events-3.0.0 into 3.0.0-wip Mar 04, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: captainpete

This relates to #6921 (closed) and #7063 (closed) where the hide event send from a tooltip causes unexpected behaviour with some configurations.

In the issues mentioned the unexpected results were due to prototype adding hide functions to Element. Well, that's prototype's problem.

This root issue is wider though; the current show, shown, hide, hidden events are too generic and can very easily conflict with code outside of bootstrap-tooltip. These events are being triggered on the element itself, how likely is it they're unique? This change safeguards against current event-name conflicts and prevents a shit-storm of future "I was already using that event name" issues.

This commit renames the events tooltip sends when visibility changes using Javascript-esq tooltipshow, tooltiphide, tooltipshown, tooltiphidden event names.

Please consider & thanks for the awesome framework 🍊 💛

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/C3/tooltip-events-3.0.0