Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !7183

Switching from $.fn.attr to $.fn.prop for checked attributes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/draeton/patch-1 into master Mar 06, 2013
  • Overview 0
  • Commits 126
  • Pipelines 0
  • Changes 235+

Created by: draeton

(This is copied from the commit)

"Toggle all" buttons do not work as expected on the customize.html page. Clicking them only un-checks the boxes; subsequent clicks do not re-check them.

Using $.fn.attr only retrieves the actual content of the "checked" attribute, so it never registers as false if there is content in the string. JQuery advises now using $.fn.prop for the checked attribute, which returns the actual value.

See: http://api.jquery.com/prop/

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/draeton/patch-1