Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !7510

Proposed fix for allowing Collapse events ('show'/'hide') to be cancelle...

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/davemurphysf/issue_5973 into 3.0.0-wip Apr 08, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: davemurphysf

Proposed fix for issue #5973 (closed)

Added tracking for if preventDefault has been called similar to how 'transitioning' is currently tracked. If that has occured, the elements are returned their previous states in show() and hide() respectively. The more complicated use case is for when a group of elements is being managed by a parent element, and calling show() triggers the other elements to be hidden. I changed the plugin definition to take an argument (a boolean) to pass to hide() in this (and only this) case so that reseting this.defaultPrevented to 0 only happens in the originating show() function. The other way to go here so that the plugin definition is not changed is to call a different hide function (hideOpenSiblings()?) in show() to hide the other elements that never resets this.defaultPrevented to 0.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/davemurphysf/issue_5973