Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !7547

Fix bootstrap-tooltip events interfering with MooTools Element.Shortcuts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/amplego/master into master Apr 11, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: cscade

MooTools Element.Shortcuts extends DOM elements with .hide() and .show() methods.

Unfortunately, because of the way jQuery .trigger() will call any methods of the same name as the event on the evented object, every time a tooltip hides, it also causes the underlying DOM element it is attached to to have it's .hide() method called.

This is obviously not desirable. This commit changes all .trigger() calls in tooltip to .triggerHandler() calls, preventing the undesirable behavior.

All bootstrap tests still pass, and the events on tooltip can still be used as intended.

See Note just before Examples in .trigger() | jQuery API Documentation for details.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/amplego/master